Guidance on metrics labels#39
Open
squaremo wants to merge 2 commits into
Open
Conversation
Metrics need explicit cardinality rules. They prevent unbounded Prometheus series growth. Stable IDs remain authoritative for alerting. Display names keep dashboards readable.
State metrics need to identify the affected resource. The exception is limited to transient or anomalous states so it does not permit general per-resource inventory metrics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to clear up what we should do with e.g., nscaledev/uni-region#470, around which there was some question over how we should label the metrics to avoid 1. name changes looking like new time series and 2. having opaque identifiers (UUIDs) in chart legends.