Put commit hygeine instructions in review prompt#12
Open
squaremo wants to merge 1 commit into
Open
Conversation
In an attempt to get consistency with commit messages, I've put some instructions here. These are a summary of https://cbea.ms/git-commit/. Note that "conventional commit" is explicitly excluded. It's no good having them sprinkled through the git history; and if I have to choose, I choose to omit the noise of those prefixes. They are not used in these repos, and I'd argue would not be usable (since they are often on commits that are squashed anyway, aren't always accurate, and take up space that could be a more thoughtful commit message.)
Contributor
Author
|
From https://github.com/nscaledev/uni-shared-workflow-tester/pull/6#issuecomment-4557030669
Well you know. One out of four ain't bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an attempt to get consistency with commit messages, I've put some instructions here. These are a summary of https://cbea.ms/git-commit/.
Note that "conventional commit" is explicitly excluded. It's no good having them sprinkled through the git history; and if I have to choose, I choose to omit the noise of those prefixes. They are not used in these repos, and I'd argue would not be usable (since they are often on commits that are squashed anyway, aren't always accurate, and take up space that could be a more thoughtful commit message.)