Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/vunit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,14 @@ jobs:
env:
VUNIT_CI_MODE: "true"
timeout-minutes: 15 # Test execution timeout

- name: Test Report
uses: dorny/test-reporter@c8370352934b730bc7f9acc17180a1f5f3964ffd # v2
if: ${{ !cancelled() }}
Copy link

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new "Test Report" step uses a different conditional (if: ${{ !cancelled() }}) compared to the other test reporting steps in the workflow (lines 68, 75, 82) which use if: always(). This inconsistency means this step won't run if the "Run VUnit tests" step fails, while the other test reporting steps will. For consistent test result reporting regardless of test outcome, consider using if: always() instead.

Suggested change
if: ${{ !cancelled() }}
if: always()

Copilot uses AI. Check for mistakes.
with:
name: VUnit Test Results
Copy link

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name "VUnit Test Results" conflicts with the check_name used in the "Publish Test Results" step at line 78. Having duplicate names can cause confusion in the GitHub UI when viewing checks and test results. Consider using a more specific name like "Test Report Summary" or "Dorny Test Reporter" to differentiate it from the other test reporting mechanisms.

Suggested change
name: VUnit Test Results
name: VUnit Test Report Summary

Copilot uses AI. Check for mistakes.
path: test-reports/vunit_results.xml
reporter: java-junit
fail-on-error: false
- name: Generate XUnit Viewer Report
uses: AutoModality/action-xunit-viewer@7cb0d0fc8cc104017ac5ebd7d9082213a311d4a2 # v1
if: always()
Expand Down
Loading