docs(audit): flag D-1 orphan-GC residual (DVR retention blind to uncatalogued blobs)#25
Merged
Merged
Conversation
…gued DVR blobs) Mark D-1 as FIXED (PARTIAL): the catalog-coverage merge does not garbage-collect blob files on disk that no catalog references (the in-progress hour at a restart, crash-dirty hours, or blobs written between catalog saves). pruneOnce only prunes catalogued hours and MaxSizeGB measures the catalog rather than actual disk usage, so orphaned blobs accumulate unboundedly across restarts. Records the production disk-full incident and the orphan-GC follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the audit report's D-1 finding to reflect reality after the partial fix.
✅ FIXED, but the catalog-coverage merge only carries forward catalogued hours. It does not garbage-collect blob files on disk that no catalog references — the in-progress hour at a restart, crash-dirty hours, or any blob written between two catalog saves.pruneOnceprunes only catalogued hours andMaxSizeGBmeasures the catalog (not actual disk usage), so orphaned blobs accumulate unboundedly across restarts.✅ FIXED (PARTIAL)with the residual called out, the production disk-full incident recorded, and an orphan-GC follow-up proposed (GC blobs not referenced by the catalog on StartRecording + periodically; make MaxSizeGB account for on-disk usage).Docs-only.