revert(ingest): remove ingest-side SSRF egress guard (operator decision)#28
Merged
Conversation
The dial-time SSRF guard on the HLS/HTTP-TS pull clients blocked private/RFC1918 targets unless an opt-in flag was set. On a server whose primary role is pulling from internal/LAN sources this is counterproductive: it caused a real failover freeze (an internal HLS input was blocked at dial, the worker reconnect-looped, no error surfaced), and it only ever covered the two HTTP-family pull protocols anyway. With the control plane now behind authentication, the unauthenticated-remote angle that made this high-severity is gone, so the ingest guard is removed. Removed: - netguard transport guard + redirect cap on the HLS and HTTP-TS clients - save-time input-URL validation in the stream handler - the allow_private_targets ingestor config flag (and its runtime hot-reload) - the egress-guard fail-fast classification in the ingest worker Kept: - the netguard package and its use by the webhook client (a hook must never reach the local admin API / metadata endpoint) - the connect-but-no-packets failover self-heal (independent) - the hooks file-root hot-reload (independent) Audit doc: the ingest SSRF finding is marked won't-fix / risk-accepted with rationale; the follow-up coverage/retroactivity bug is marked ignore. make check green (build + vet + lint + test -race).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the ingest-side SSRF egress guard, by operator decision.
The dial-time guard on the HLS / HTTP-TS pull clients blocked private/RFC1918 targets unless
allow_private_targetswas set. On a server whose primary role is pulling from internal / LAN sources, that is counterproductive:With the control plane now behind authentication, the unauthenticated-remote angle that made this high-severity is gone, so the ingest guard is removed.
Removed
netguardtransport guard + redirect cap on the HLS and HTTP-TS clientsallow_private_targetsingestor config flag (and its runtime hot-reload)Kept
netguardpackage and its use by the webhook client (a hook must never reach the local admin API / metadata endpoint)Audit doc
The ingest SSRF finding (S-4) is marked won't-fix / risk-accepted with rationale; the follow-up coverage/retroactivity bug is marked ignore.
Tests
make checkgreen — build + vet + lint (0 issues) + test -race (32 packages). Swagger regenerated.