Add macos workflow compatibility#82
Conversation
Ian0sborne
force-pushed
the
add-macos-workflow-compatibility
branch
from
f891bf0 to
c7d4e99
Compare
|
Apparently |
Ian0sborne
force-pushed
the
add-macos-workflow-compatibility
branch
from
e85a791 to
2784ab1
Compare
jwaiton
left a comment
jwaiton
left a comment
There was a problem hiding this comment.
Looks good! Just some small tweaks.
|
|
||
| PYTEST_ADDOPTS=--color=yes HYPOTHESIS_PROFILE=travis-ci python -m pytest -v | ||
| PYTEST_ADDOPTS=--color=yes HYPOTHESIS_PROFILE=travis-ci \ | ||
| conda run -n MULE-3.12-10-24 python -m pytest -v |
There was a problem hiding this comment.
hardcoding the conda environment here scares me, although Im unsure of a better alternative at the moment.
| else | ||
| echo "No Conda installation detected, installing conda." | ||
| echo 'Download conda? Select [1/2]:' | ||
| select yn in Yes No; do | ||
| case $yn in | ||
| Yes ) install_conda; break;; | ||
| No ) echo "MULE activation aborted"; return;; |
There was a problem hiding this comment.
An inherent problem here is that you want the user to have choice in the installation of conda, but lines 20-46 install and initialise conda anyway. I'd remove the check to see if the user has conda and wants it installed, but warn the user with an echo that conda is being installed perhaps.
There was a problem hiding this comment.
Looking at the code it seems to me that lines 20-46 define the conda installation function but don't actually call it. Hence the user prompt of yes/no actually does do something. If you want this do be removed and conda to be installed regardless I can do that of course!
3 participants
This PR builds on #56 and implements the final changes needed to ensure that GitHub workflow test suites are able to catch non-functionality with MacOS systems before PRs are merged.