Prevent accidental usage of _blank_ and _comment_#2
Open
SabrinaJewson wants to merge 1 commit intonu11ptr:masterfrom
Open
Prevent accidental usage of _blank_ and _comment_#2SabrinaJewson wants to merge 1 commit intonu11ptr:masterfrom
_blank_ and _comment_#2SabrinaJewson wants to merge 1 commit intonu11ptr:masterfrom
Conversation
Owner
|
This seems like a good idea. Will likely accept this PR after I give a bit more thought and review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help to prevent misuse of those macros, unless there's a valid use case for calling them I'm missing?