rust-format: post-processing for module-level rustdoc attributes#3
Open
tomkris wants to merge 1 commit intonu11ptr:masterfrom
Open
rust-format: post-processing for module-level rustdoc attributes#3tomkris wants to merge 1 commit intonu11ptr:masterfrom
tomkris wants to merge 1 commit intonu11ptr:masterfrom
Conversation
Module level rustdoc has different syntax than regular rustdoc: ``` //! my documentation or #![doc="my documantation"] ``` Right now this case is not handled by the post-processor and module level documentation attributes are not converted to their comment counterparts when doc post-processing is enabled.
Owner
|
Nice - I'll give it a look over. Thx for the submission |
Author
|
@nu11ptr , I wanted to check if any additional information from my side will help with reviewing this PR? Please let me know, I'm very interested to have this fix merged it. Thanks! |
Owner
|
Sorry, just been busy at work last couple of months on a big project. Hope to get a chance to look at this soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module level rustdoc has different syntax than regular rustdoc:
Right now this case is not handled by the post-processor and module
level documentation attributes are not converted to their comment
counterparts when doc post-processing is enabled.