Skip to content
This repository was archived by the owner on Aug 30, 2025. It is now read-only.

NEOS-1558: Fixes multi-az SSH Tunnel, exposes check ssh tunnel on frontend#3419

Merged
nickzelei merged 11 commits intomainfrom
nick/neos-1558-expose-ability-on-frontend-to-verify-bastion-tunnel
Mar 27, 2025
Merged

NEOS-1558: Fixes multi-az SSH Tunnel, exposes check ssh tunnel on frontend#3419
nickzelei merged 11 commits intomainfrom
nick/neos-1558-expose-ability-on-frontend-to-verify-bastion-tunnel

Conversation

@nickzelei
Copy link
Copy Markdown
Member

@nickzelei nickzelei commented Mar 27, 2025

The issue we saw with the multi-az setup was that it indeed was able to resolve the IP address, but could not connect to it for some reason. Overriding the LookupFunc to instead return the hostname allowed connection to succeed.

@linear
Copy link
Copy Markdown

linear bot commented Mar 27, 2025

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2025 9:06pm

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 27, 2025, 9:06 PM

@nickzelei nickzelei changed the title Nick/neos 1558 expose ability on frontend to verify bastion tunnel NEOS-1558: Fixes multi-az SSH Tunnel, exposes check ssh tunnel on frontend Mar 27, 2025
@nickzelei nickzelei added bug Something isn't working enhancement New feature or request labels Mar 27, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2025

Benchstat Geomean Results

-4.33% sec/op, -0.03% B/op, 0.97% allocs/op

Benchstat results
                                   │ main-benchmark.txt │         branch-benchmark.txt         │
                                   │       sec/op       │    sec/op      vs base               │
CleanPostgresType-4                         42.63n ± 4%    42.52n ±  5%        ~ (p=0.669 n=6)
Runner_Single-4                             7.713µ ± 5%    7.484µ ±  4%   -2.97% (p=0.026 n=6)
GenerateBool-4                              11.45n ± 1%    11.66n ±  5%   +1.83% (p=0.032 n=6)
GenerateBusinessName-4                      285.4n ± 0%    273.6n ± 11%        ~ (p=0.065 n=6)
GenerateCardNumber-4                        28.41n ± 1%    27.28n ±  1%   -3.96% (p=0.002 n=6)
GenerateCategorical-4                      104.10n ± 2%    92.67n ±  0%  -10.98% (p=0.002 n=6)
GenerateCity-4                              173.7n ± 0%    174.2n ±  0%        ~ (p=0.199 n=6)
GenerateCountry-4                          105.20n ± 1%    97.28n ±  0%   -7.52% (p=0.002 n=6)
GenerateEmail-4                             1.346µ ± 0%    1.301µ ±  1%   -3.38% (p=0.002 n=6)
GenerateFirstName-4                         203.9n ± 0%    197.0n ±  3%   -3.38% (p=0.009 n=6)
GenerateFloat64-4                           28.73n ± 1%    26.57n ±  0%   -7.52% (p=0.002 n=6)
GenerateFullAddress-4                       1.429µ ± 3%    1.426µ ±  1%        ~ (p=0.329 n=6)
GenerateFullName-4                          1.222µ ± 1%    1.230µ ±  5%        ~ (p=1.000 n=6)
GenerateGender-4                            41.42n ± 0%    37.10n ±  0%  -10.43% (p=0.002 n=6)
GenerateInt64-4                             28.41n ± 2%    26.73n ±  0%   -5.88% (p=0.002 n=6)
GenerateInt64PhoneNumber-4                  51.46n ± 2%    50.45n ±  0%   -1.96% (p=0.002 n=6)
GenerateInternationalPhoneNumber-4          175.8n ± 1%    169.4n ±  0%   -3.64% (p=0.002 n=6)
GenerateIpAddress-4                         569.3n ± 0%    517.8n ±  1%   -9.05% (p=0.002 n=6)
GenerateLastName-4                          187.4n ± 1%    182.8n ±  2%   -2.48% (p=0.002 n=6)
GenerateRandomString-4                      985.6n ± 1%   1019.0n ±  0%   +3.39% (p=0.002 n=6)
GenerateSHA256Hash-4                       1016.5n ± 0%    970.9n ±  0%   -4.49% (p=0.002 n=6)
GenerateSSN-4                               305.8n ± 1%    269.8n ±  2%  -11.77% (p=0.002 n=6)
GenerateState-4                            105.15n ± 2%    97.17n ±  1%   -7.58% (p=0.002 n=6)
GenerateStreetAddress-4                     204.0n ± 1%    203.0n ±  0%   -0.47% (p=0.024 n=6)
GenerateStringPhoneNumber-4                 179.3n ± 0%    161.6n ±  1%   -9.90% (p=0.002 n=6)
GenerateUnixTimestamp-4                     77.13n ± 1%    76.77n ±  0%   -0.47% (p=0.011 n=6)
GenerateUsername-4                          351.5n ± 0%    345.8n ±  1%   -1.62% (p=0.002 n=6)
GenerateUTCTimestamp-4                     104.25n ± 1%    99.10n ±  0%   -4.94% (p=0.002 n=6)
GenerateUUID-4                              734.0n ± 0%    727.8n ±  0%   -0.85% (p=0.004 n=6)
GenerateZipcode-4                          105.15n ± 2%    94.40n ±  0%  -10.22% (p=0.002 n=6)
TransformCharacterScramble-4                171.8n ± 1%    164.0n ±  1%   -4.48% (p=0.002 n=6)
TransformE164PhoneNumber-4                  180.2n ± 3%    170.9n ±  0%   -5.19% (p=0.002 n=6)
TransformEmail-4                            1.798µ ± 2%    1.728µ ±  1%   -3.89% (p=0.002 n=6)
TransformFirstName-4                        233.9n ± 0%    233.4n ±  1%        ~ (p=0.210 n=6)
TransformFloat64-4                          110.8n ± 4%    100.5n ±  0%   -9.34% (p=0.002 n=6)
TransformFullName-4                         1.235µ ± 2%    1.208µ ±  2%   -2.19% (p=0.002 n=6)
TransformInt64-4                            33.74n ± 1%    31.60n ±  0%   -6.33% (p=0.002 n=6)
TransformInt64PhoneNumber-4                 57.84n ± 2%    57.19n ±  0%   -1.12% (p=0.002 n=6)
TransformLastName-4                         191.6n ± 0%    190.1n ±  0%   -0.76% (p=0.002 n=6)
TransformString-4                           1.022µ ± 0%    1.046µ ±  1%   +2.30% (p=0.002 n=6)
TransformStringPhoneNumber-4                211.0n ± 2%    185.3n ±  0%  -12.16% (p=0.002 n=6)
TransformUuid-4                             36.54n ± 1%    32.53n ±  0%  -10.96% (p=0.002 n=6)
geomean                                     194.0n         185.6n         -4.33%

                                   │ main-benchmark.txt │         branch-benchmark.txt         │
                                   │        B/op        │     B/op      vs base                │
CleanPostgresType-4                        0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                          2.312Ki ± 1%     2.280Ki ± 1%  -1.41% (p=0.006 n=6)
GenerateBool-4                             0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     304.0 ± 0%       304.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      64.00 ± 0%       64.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             160.0 ± 0%       160.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            385.0 ± 0%       385.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      512.0 ± 0%       512.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            7.000 ± 0%       7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        31.00 ± 0%       31.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     186.0 ± 0%       186.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       288.0 ± 0%       288.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              46.00 ± 0%       46.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    240.0 ± 0%       240.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         205.0 ± 0%       205.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             80.00 ± 0%       80.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               40.00 ± 3%       40.00 ± 0%       ~ (p=0.455 n=6)
TransformE164PhoneNumber-4                 40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           489.0 ± 0%       489.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       224.0 ± 0%       224.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         88.00 ± 0%       88.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          202.0 ± 0%       202.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               56.00 ± 0%       56.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²                 -0.03%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                   │ main-benchmark.txt │         branch-benchmark.txt         │
                                   │     allocs/op      │  allocs/op   vs base                 │
CleanPostgresType-4                        0.000 ± 0%     0.000 ±  0%        ~ (p=1.000 n=6) ¹
Runner_Single-4                            24.00 ± 0%     24.00 ±  0%        ~ (p=1.000 n=6) ¹
GenerateBool-4                             0.000 ± 0%     0.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       1.000 ± 0%     1.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateCity-4                             2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateCountry-4                          2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateEmail-4                            8.000 ± 0%     8.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          1.000 ± 0%     1.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      10.00 ± 0%     10.00 ±  0%        ~ (p=1.000 n=6) ¹
GenerateFullName-4                         6.000 ± 0%     6.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateGender-4                           1.000 ± 0%     1.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateInt64-4                            0.000 ± 0%     0.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 1.000 ± 0%     1.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         3.000 ± 0%     3.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateLastName-4                         2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     3.000 ± 0%     3.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       7.000 ± 0%     7.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateSSN-4                              3.000 ± 0%     3.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateState-4                            2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                3.000 ± 0%     3.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    1.000 ± 0%     1.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateUsername-4                         6.000 ± 0%     6.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     1.000 ± 0%     1.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateUUID-4                             3.000 ± 0%     3.000 ±  0%        ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               2.000 ± 0%     3.000 ± 33%  +50.00% (p=0.015 n=6)
TransformE164PhoneNumber-4                 3.000 ± 0%     3.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformEmail-4                           14.00 ± 0%     14.00 ±  0%        ~ (p=1.000 n=6) ¹
TransformFirstName-4                       3.000 ± 0%     3.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformFloat64-4                         3.000 ± 0%     3.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformFullName-4                        6.000 ± 0%     6.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformInt64-4                           1.000 ± 0%     1.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                1.000 ± 0%     1.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformLastName-4                        2.000 ± 0%     2.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformString-4                          4.000 ± 0%     4.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               4.000 ± 0%     4.000 ±  0%        ~ (p=1.000 n=6) ¹
TransformUuid-4                            1.000 ± 0%     1.000 ±  0%        ~ (p=1.000 n=6) ¹
geomean                                               ²                 +0.97%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

@nickzelei nickzelei marked this pull request as ready for review March 27, 2025 20:58
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 9.09091% with 110 lines in your changes missing coverage. Please review.

Project coverage is 24.33%. Comparing base (06cf6da) to head (37caf46).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ces/mgmt/v1alpha1/connection-service/connection.go 0.00% 58 Missing ⚠️
internal/sshtunnel/utils.go 23.91% 35 Missing ⚠️
...unnel/connectors/postgrestunconnector/connector.go 0.00% 9 Missing and 1 partial ⚠️
internal/sshtunnel/dialer.go 0.00% 4 Missing ⚠️
backend/pkg/sqlconnect/sql-connector.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3419      +/-   ##
==========================================
- Coverage   24.39%   24.33%   -0.07%     
==========================================
  Files         417      417              
  Lines       49352    49396      +44     
==========================================
- Hits        12041    12020      -21     
- Misses      36175    36242      +67     
+ Partials     1136     1134       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nickzelei nickzelei merged commit fc32052 into main Mar 27, 2025
22 of 24 checks passed
@nickzelei nickzelei deleted the nick/neos-1558-expose-ability-on-frontend-to-verify-bastion-tunnel branch March 27, 2025 21:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants