Skip to content

Fixes creating a KB from an Import#2778

Draft
carlesonielfa wants to merge 2 commits intomainfrom
fix-import
Draft

Fixes creating a KB from an Import#2778
carlesonielfa wants to merge 2 commits intomainfrom
fix-import

Conversation

@carlesonielfa
Copy link
Copy Markdown
Contributor

Description

Had some issues importing a KB from hosted to standalone, this fixes it.

Another approach might be to remove these fields at export time, but then that exported fields wouldn't match those defined here:

class SemanticConfig(BaseModel):

How was this PR tested?

Describe how you tested this PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.53%. Comparing base (f612bd3) to head (c55416f).
⚠️ Report is 776 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2778      +/-   ##
==========================================
- Coverage   87.13%   82.53%   -4.60%     
==========================================
  Files         386      386              
  Lines       24293    24295       +2     
==========================================
- Hits        21167    20053    -1114     
- Misses       3126     4242    +1116     
Flag Coverage Δ
nucliadb 65.31% <100.00%> (-9.46%) ⬇️
nucliadb-ingest 40.73% <0.00%> (-0.01%) ⬇️
nucliadb-reader 42.74% <0.00%> (-0.01%) ⬇️
nucliadb-search 43.58% <0.00%> (-0.01%) ⬇️
nucliadb-standalone 47.47% <100.00%> (+<0.01%) ⬆️
nucliadb-train 45.70% <0.00%> (-0.01%) ⬇️
nucliadb-writer 46.20% <100.00%> (+<0.01%) ⬆️
nucliadb_dataset ∅ <ø> (∅)
nucliadb_models 86.89% <ø> (ø)
nucliadb_sdk 86.70% <ø> (ø)
nucliadb_sidecar ∅ <ø> (∅)
nucliadb_telemetry 86.56% <ø> (ø)
nucliadb_utils 81.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants