fix: Remove isomorphic-fetch and isomorphic-form-data polyfills#141
Draft
lollipop-onl wants to merge 1 commit intonulab:masterfrom
Draft
fix: Remove isomorphic-fetch and isomorphic-form-data polyfills#141lollipop-onl wants to merge 1 commit intonulab:masterfrom
lollipop-onl wants to merge 1 commit intonulab:masterfrom
Conversation
Node.js v18+ provides built-in fetch and FormData globals, making these polyfills unnecessary. Add engines field requiring Node.js >= 18. Closes nulab#87 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isomorphic-fetchandisomorphic-form-datapolyfills, asfetchandFormDataare available as built-in global APIs in Node.js v18 and later.engines.node: ">= 18"topackage.jsonto specify the minimum required Node.js version.Note
This change does not affect the runtime source code. Additionally, adding the engines field only triggers a warning and does not block user operations. Therefore, this change does not qualify as a breaking change.
References