ci: split build and test jobs and modernize CI workflow#143
Merged
mmktomato merged 6 commits intonulab:masterfrom Mar 23, 2026
Merged
ci: split build and test jobs and modernize CI workflow#143mmktomato merged 6 commits intonulab:masterfrom
mmktomato merged 6 commits intonulab:masterfrom
Conversation
Split the single test job into build and test jobs so that the Node.js version matrix only applies to test execution. Build runs once on Node.js 22.x and passes artifacts to the test matrix (18.x, 20.x, 22.x). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use lts/* instead of a hardcoded version for the build job so it automatically tracks the latest LTS release. Add Node.js 24.x to the test matrix for early compatibility testing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- actions/checkout v3 → v6 - actions/setup-node v3 → v6 - actions/upload-artifact v4 → v7 - actions/download-artifact v4 → v8 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lollipop-onl
changed the title
Remove upload/download-artifact steps since tests run against source directly, not built artifacts. Build uses Node.js 22 instead of lts/*. Limit push trigger to master to avoid duplicate runs with pull_request. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
@lollipop-onl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
rolldown(used by tsdown) requires Node.js >= 20.12.0, so the build step is run once on Node.js 22 and only tests are run across the version matrix.