Skip to content

fix(cert-manager-config): use managedIdentity.clientID for Azure Workload Identity #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gdrojas merged 2 commits into from
Mar 30, 2026
Merged

fix(cert-manager-config): use managedIdentity.clientID for Azure Workload Identity #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea4fd36
fix(cert-manager-config): use managedIdentity.clientID for Azure Work…
gdrojas Mar 30, 2026
9a206da
feat(cert-manager-config): support both Workload Identity and Service…
gdrojas Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions charts/cert-manager-config/templates/cluster-issuer-private.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,20 @@ spec:
project: "{{ .Values.gcp.projectId }}"
{{- else if eq .Values.cloudProvider "azure" }}
azureDNS:
clientID: {{ .Values.azure.clientID }}
subscriptionID: {{ .Values.azure.subscriptionID }}
tenantID: {{ .Values.azure.tenantID }}
resourceGroupName: {{ .Values.azure.resourceGroupName }}
hostedZoneName: {{ .Values.azure.hostedZoneName }}
environment: AzurePublicCloud
config:
useWorkloadIdentityExtension: true
{{- if .Values.azure.useWorkloadIdentity }}
managedIdentity:
clientID: {{ required "azure.clientID is required" .Values.azure.clientID | quote }}
{{- else }}
tenantID: {{ required "azure.tenantID is required" .Values.azure.tenantID | quote }}
clientID: {{ required "azure.clientID is required" .Values.azure.clientID | quote }}
clientSecretSecretRef:
name: {{ required "azure.clientSecret.secretName is required" .Values.azure.clientSecret.secretName | quote }}
key: {{ .Values.azure.clientSecret.secretKey | default "client-secret" | quote }}
{{- end }}
{{- else if eq .Values.cloudProvider "cloudflare" }}
cloudflare:
apiTokenSecretRef:
Expand Down
12 changes: 10 additions & 2 deletions charts/cert-manager-config/templates/cluster-issuer-public.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,16 @@ spec:
resourceGroupName: {{ required "azure.resourceGroupName is required" .Values.azure.resourceGroupName | quote }}
hostedZoneName: {{ .Values.hostedZoneName }}
environment: AzurePublicCloud
config:
useWorkloadIdentityExtension: true
{{- if .Values.azure.useWorkloadIdentity }}
managedIdentity:
clientID: {{ required "azure.clientID is required" .Values.azure.clientID | quote }}
{{- else }}
tenantID: {{ required "azure.tenantID is required" .Values.azure.tenantID | quote }}
clientID: {{ required "azure.clientID is required" .Values.azure.clientID | quote }}
clientSecretSecretRef:
name: {{ required "azure.clientSecret.secretName is required" .Values.azure.clientSecret.secretName | quote }}
key: {{ .Values.azure.clientSecret.secretKey | default "client-secret" | quote }}
{{- end }}
{{- else if eq .Values.cloudProvider "cloudflare" }}
cloudflare:
apiTokenSecretRef:
Expand Down
4 changes: 4 additions & 0 deletions charts/cert-manager-config/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ azure:
clientID: ""
tenantID: ""
hostedZoneName: ""
useWorkloadIdentity: true
clientSecret:
secretName: ""
secretKey: "client-secret"
cloudflare:
secretName: "cloudflare-api-token-secret"
apiToken: ""
Expand Down
Loading