chore: remove unused nrn variable from base module#297
Merged
agustincelentano merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
The nrn variable was declared but never consumed by any resource. Its only reference computed nrn_without_namespace in locals.tf, which was not used anywhere else in the module.
sebastiancorrea81
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
variable "nrn"fromnullplatform/base/variables.tf(was declared but never consumed by any resource).nrn_without_namespacelocal fromnullplatform/base/locals.tf(its only use was its own definition; no downstream reference).Why
The
basemodule acceptednrnas input but none of its resources (twokubernetes_namespace_v1and ahelm_release) used the value. The template rendered into the helm release does not include NRN either. Passing the variable created a false signal thatbaseneeded to be re-applied when the account changed — it didn't.Breaking change
Consumers still passing
nrn = ...tomodule "base"will get:They should drop that argument. Same pattern as the
np_api_keycleanups already shipped in v1.53.0 for other modules.Test plan