fix: return detailed vertex status message when unhealthy#3502
Open
AyushSrivastava1818 wants to merge 1 commit into
Open
fix: return detailed vertex status message when unhealthy#3502AyushSrivastava1818 wants to merge 1 commit into
AyushSrivastava1818 wants to merge 1 commit into
Conversation
AyushSrivastava1818
requested review from
vigith,
whynowy and
yhl25
as code owners
Member
|
can you fix DCO check? (signed commit) |
Signed-off-by: AyushSrivastava1818 <ayush.sri0705@gmail.com>
AyushSrivastava1818
force-pushed
the
fix/vertex-status-message
branch
from
8701bf1 to
7ff0df6
Compare
| } | ||
| if !vertex.Status.IsHealthy() { | ||
| if vertex.Status.Message != "" { | ||
| return false, "Unavailable", vertex.Status.Message |
Contributor
There was a problem hiding this comment.
Suggested change
| return false, "Unavailable", vertex.Status.Message | |
| return false, "Unavailable", `Vertex "` + vertex.Spec.Name + `" error: ` + vertex.Status.Message |
Contributor
|
Can you please also provide example of how this message appears in status from a running pipeline that is failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
When a vertex is unhealthy,
CheckVertexStatuscurrently returns a generic message:This hides the more detailed diagnostic information already available in
vertex.Status.Message.This PR updates
CheckVertexStatusto returnvertex.Status.Messagewhen it is available, while preserving the existing generic fallback message when no detailed status message exists.Additionally, a unit test has been added to verify the new behavior without changing the existing fallback behavior.
Related issues
Fixes #3496
Testing
gofmt -w pkg/reconciler/util.go pkg/reconciler/util_test.go go test ./pkg/reconciler/...