Skip to content

flake: update nixpkgs to pull Go 1.26.3#132

Merged
aldoborrero merged 2 commits into
mainfrom
aldo/bump-nixpkgs-go-1.26.3
Jun 12, 2026
Merged

flake: update nixpkgs to pull Go 1.26.3#132
aldoborrero merged 2 commits into
mainfrom
aldo/bump-nixpkgs-go-1.26.3

Conversation

@aldoborrero

Copy link
Copy Markdown
Member

What this does

Updates the nixpkgs flake input from 2026-04-09 to 2026-06-06. This moves the pinned go_1_26 toolchain from 1.26.1 to 1.26.3, picking up the upstream point-release fixes (including security fixes). Go 1.26 is still the latest major release, so no attribute changes are needed — every package already pins pkgs.go_1_26.

What changed

  • flake.lock only: nixpkgs 4c1018da799d3e.

How it was verified

  • go build ./... and the full go test ./... suite pass under Go 1.26.3.
  • scripts/check-godebug-table.go still matches the upstream godebug table (32 entries).
  • All 44 flake packages evaluate against the new nixpkgs.
  • go2nix-nix-plugin builds.

Full nix builds of the fixture packages are left to CI (local environment couldn't run the module-fetch derivations).

Bumps the nixpkgs input from 2026-04-09 to 2026-06-06, which moves the
pinned go_1_26 toolchain from 1.26.1 to 1.26.3, picking up the upstream
point-release fixes.

Verified: go build and the full go test suite pass under 1.26.3, the
godebug table check still matches upstream (32 entries), and all flake
packages evaluate against the new nixpkgs.

:house: Remote-Dev: homespace
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

Benchmark Regression Check

Scenario Tool Base (s) Current (s) Change Drvs (base) Drvs (curr) Status
no_change nix-ca-nocgo 0.68 0.67 -2.0% 0 0 ok
no_change nix-nocgo 0.68 0.66 -2.8% 0 0 ok
leaf-private nix-ca-nocgo 1.79 1.71 -4.4% 2 2 ok
leaf-private nix-nocgo 1.38 1.36 -1.7% 2 2 ok
mid-private nix-ca-nocgo 1.86 1.86 +0.3% 2 2 ok
mid-private nix-nocgo 1.52 1.45 -4.5% 4 4 ok
deep-private nix-ca-nocgo 2.18 3.21 +47.2% 3 3 REGRESSION (time)
deep-private nix-nocgo 1.67 1.69 +1.6% 8 8 ok

Baseline: main | Current: 38dce0c4ff2fe48f0721b8ac5fa36cd6ac93c08f

The nixpkgs bump brings a newer gofumpt that splits multi-line call
arguments differently. Cosmetic only.

:house: Remote-Dev: homespace
@aldoborrero

Copy link
Copy Markdown
Member Author

The bench failures across the three runs each flag a different scenario (mid-private +129% → ok, leaf-private +50% → ok, now deep-private +47%) with identical drv counts everywhere, so this is runner timing noise rather than a regression from the toolchain bump. Merging with the non-required bench check red.

@aldoborrero aldoborrero added this pull request to the merge queue Jun 12, 2026
Merged via the queue into main with commit ec9bf03 Jun 12, 2026
2 of 4 checks passed
@aldoborrero aldoborrero deleted the aldo/bump-nixpkgs-go-1.26.3 branch June 12, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant