Skip to content

feat: upgrade charmbracelet/log to v2#703

Merged
brianmcgee merged 1 commit into
mainfrom
charmbracelet-log-v2
Jun 2, 2026
Merged

feat: upgrade charmbracelet/log to v2#703
brianmcgee merged 1 commit into
mainfrom
charmbracelet-log-v2

Conversation

@brianmcgee

Copy link
Copy Markdown
Member

Straightforward upgrade, just import path changes.

V2 has switched to charmbracelet/colorprofile which doesn't send OSC queries and has better terminal color support in general.

Fixes #697

@brianmcgee brianmcgee requested review from jfly and zimbatm June 2, 2026 11:13

@jfly jfly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Teach me about the go ecosystem: Dependabot didn't send us this update, because go lib authors tend to treat breaking changes as a new library?

How do we check if we're using other effectively unmaintained dependencies?

Straightforward upgrade, just import path changes.

V2 has switched to charmbracelet/colorprofile which doesn't send OSC queries and has better terminal color support in general.

Fixes #697

Signed-off-by: Brian McGee <brian@bmcgee.ie>
@brianmcgee brianmcgee force-pushed the charmbracelet-log-v2 branch from 02911ce to 6e0d325 Compare June 2, 2026 15:27
@brianmcgee

Copy link
Copy Markdown
Member Author

This was a special case. Renovate didn't pick it up because they changed the module path from github.com/charmbracelet/log to charm.land/log/v2.

@brianmcgee brianmcgee merged commit 1d23889 into main Jun 2, 2026
6 checks passed
@brianmcgee brianmcgee deleted the charmbracelet-log-v2 branch June 2, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to charmbracelet/log v2 to fix 10s delay under lefthook/pre-commit hooks

2 participants