feat(list_menu): add DescriptionPosition to control description place…#1044
Open
a-rookie-of-C-language wants to merge 2 commits intonushell:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
DescriptionPositionenum that lets callers choose whether thecompletion description is rendered before or after the value in a
ListMenurow.Previously the position was hardcoded as
(description) value.The new default keeps that behaviour (
Before) for backwardscompatibility; setting
Afterrendersvalue descriptioninstead,which is more natural for flag/option completions where the value
(e.g.
--regexp) should visually come first.Changes:
DescriptionPositionenum withBefore(default) andAftervariantsListMenu::description_positionfield (default:Before)ListMenu::with_description_position()builder methodcreate_string()branches onself.description_positionDescriptionPositionfrommenu/mod.rsandlib.rsThis mirrors the existing
IdeMenu::with_description_mode()pattern.