refactor!: graceful handle ReedlineEvent::CtrlC#1051
Open
tisonkun wants to merge 2 commits intonushell:mainfrom
Open
refactor!: graceful handle ReedlineEvent::CtrlC#1051tisonkun wants to merge 2 commits intonushell:mainfrom
tisonkun wants to merge 2 commits intonushell:mainfrom
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Contributor
Author
|
cc @cptpiepmatz @fdncred in case if you have time to drop a review |
fdncred
reviewed
Apr 15, 2026
fdncred
requested changes
Apr 15, 2026
Contributor
Author
|
@fdncred I'm waiting for this PR to be released to use in my project. Are there any other blockers, or is there some estimation I can expect? |
Contributor
|
I've been waiting for our patch release which happened just a few minutes ago. I'll probably land this PR tomorrow or the next day. |
Contributor
Author
|
Thanks for your information! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #1050
This aligns the manner of
ReedlineEvent::CtrlD. I don't know whatself.deactivate_menus();does so do my guess to put it in theif self.editor.is_empty()branch.