Fix panic in long item completion in ide menu#823
Merged
fdncred merged 1 commit intonushell:mainfrom Sep 6, 2024
Merged
Conversation
Contributor
|
This is how I was able to repro the bug and test this fix.
Thanks for fixing this. Let's go! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ide menu uses
...for items that are very long, and if the prompt already contains some string inside of...it will panic. It can be reproduced by completing the largest item in theide_completions, then deleting one or two characters, and hittingTabagain.The panic was found in #821