Remove Dplyr+Magrittr and Add Poorman#122
Open
alex-gable wants to merge 7 commits intonutterb:mainfrom
Open
Conversation
alex-gable
changed the title
Owner
|
I assure I'm not ignoring this. I'm quite interested in anything that can reduce my dependency footprint. I'm just not in a position to give this as thorough a review as it deserves right now. You'll likely see an update to pixiedust go up to CRAN in the coming days. This is for a change requested by CRAN and must be handled in the next few days or the package will be archived. |
Author
|
No problem! Is there a branch I could rebase off of? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Love this package, but ran into some issues with internals, specifically those using
dplyr.Made updates to port the package off of
dplyr+magrittrand ontopoorman. The only issue I ran into blocking a "clean" port over was nathaneastwood/poorman#68Most of these changes are whitespace changes which can be suppressed from the diff view.
Didn't know what to do with the Author/Maintainer/Version stuff so just threw in some fillers.
I realize this is "forward" or presumptuous and would be more than happy to walk through this in more detail!
Thanks for looking!