cmake: Search for private modules with Qt 6.10

[Integral-Tech]

According to What's New in Qt 6.10:

Usage of a private Qt module Foo now requires a call to find_package(Qt6 COMPONENTS FooPrivate) to make the Qt6::FooPrivate target available.

Otherwise, the build complains about:

CMake Error at CMakeLists.txt:354 (target_link_libraries):
  Target "Notes" links to:

    Qt6::CorePrivate

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

[zjeffer]

Thanks!

[guihkx]

Thank you for working on this.

I think we can simplify these changes a bit...

Instead of 3 separate if statements, you could probably write it like this:

# https://doc.qt.io/qt-6/whatsnew610.html#build-system-changes
if(QT_VERSION VERSION_GREATER_EQUAL 6.10)
  list(APPEND QT_COMPONENTS CorePrivate GuiPrivate WidgetsPrivate)
endif()

This would have to go before the call to find_package(Qt${QT_VERSION_MAJOR} REQUIRED COMPONENTS ${QT_COMPONENTS}).

[zjeffer]

Thank you for working on this.

I think we can simplify these changes a bit...

Instead of 3 separate if statements, you could probably write it like this:

# https://doc.qt.io/qt-6/whatsnew610.html#build-system-changes
if(QT_VERSION VERSION_GREATER_EQUAL 6.10)
  list(APPEND QT_COMPONENTS CorePrivate GuiPrivate WidgetsPrivate)
endif()

This would have to go before the call to find_package(Qt${QT_VERSION_MAJOR} REQUIRED COMPONENTS ${QT_COMPONENTS}).

This is how it was originally when I approved, not sure why it was changed 🤔

[guihkx]

Ah, I see...

Commit 0c9c248 had the changes I suggested, but it doesn't work with Qt 6.10 because it's not in the right place: The $QT_VERSION variable is still undefined in that "if" statement.

If we move the "if" statement just one line above find_package(Qt${QT_VERSION_MAJOR ..., as I suggested in my previous post, it builds just fine.

[Integral-Tech]

Thank you for working on this.

I think we can simplify these changes a bit...

Instead of 3 separate if statements, you could probably write it like this:

# https://doc.qt.io/qt-6/whatsnew610.html#build-system-changes
if(QT_VERSION VERSION_GREATER_EQUAL 6.10)
  list(APPEND QT_COMPONENTS CorePrivate GuiPrivate WidgetsPrivate)
endif()

This would have to go before the call to find_package(Qt${QT_VERSION_MAJOR} REQUIRED COMPONENTS ${QT_COMPONENTS}).

Thanks for your suggestion :)

[guihkx]

@Integral-Tech Thanks!

@zjeffer Can you add this as a patch to the notes AUR package? Thanks!

[zjeffer]

@guihkx done: https://aur.archlinux.org/cgit/aur.git/commit/?h=notes&id=96e34dcabe19ed5a14f42e45640e65917a064966

[nuttyartist]

Thanks to all involved! @Integral-Tech @guihkx @zjeffer !