Fix macOS frameless window initialization and titlebar toggle#759
Merged
nuttyartist merged 1 commit intomasterfrom Oct 12, 2025
Merged
Fix macOS frameless window initialization and titlebar toggle#759nuttyartist merged 1 commit intomasterfrom
nuttyartist merged 1 commit intomasterfrom
Conversation
guihkx
approved these changes
Oct 12, 2025
Collaborator
There was a problem hiding this comment.
These changes only really affect macOS, and I don't have a macOS machine to test this... :P
The modified header file is also used on Windows, but it's a one line change, so it shouldn't matter anyway.
But the changes make sense to me.
Can you please squash all 4 commits into one before merging? Thanks.
zjeffer
approved these changes
Oct 12, 2025
Collaborator
zjeffer
left a comment
zjeffer
left a comment
There was a problem hiding this comment.
Also can't test it but code looks good
Owner
Author
|
Tested now on Windows as well and looks good. Will squash and merge. |
nuttyartist
force-pushed
the
fix-frameless-window-init
branch
from
eee2c26 to
6f4060b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix macOS frameless window initialization timing
Defer
initUI()call from constructor to firstshowEventto ensure native window is fully created.