Add instructions about translation workflow#9671
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the submitter documentation to reflect that Crowdin-based translation support is now available via the NVDA Add-on Template, replacing outdated guidance.
Changes:
- Removes the statement that no recommended translation system is available.
- Updates wording to indicate Crowdin support is added to the Add-on Template.
- Adds a direct link to the template’s translation workflow documentation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Translations via Crowdin support is being added to [the Add-on Template](https://github.com/nvaccess/AddonTemplate) as a work in progress currently. | ||
| Translations via Crowdin support has been added to [the Add-on Template](https://github.com/nvaccess/AddonTemplate). | ||
|
|
||
| Please see the [add-on template Translation workflow section](https://github.com/nvaccess/AddonTemplate/#translation-workflow) for more details. |
|
@seanbudd Feel free to review this when you can. This is ready. |
| Translations via Crowdin support has been added to [the Add-on Template](https://github.com/nvaccess/AddonTemplate). | ||
|
|
||
| Please see the [add-on template Translation workflow section](https://github.com/nvaccess/AddonTemplate/#translation-workflow) for more details. |
There was a problem hiding this comment.
Hmm - I tend to agree. I think we need a dedicated docs file / folder explaining 2 different things:
- how to set up syncing as an add-on author
- how to translate add-ons as a translator
|
@seanbudd wrote: Hmm - I tend to agree. I think we need a dedicated docs file / folder explaining 2 different things: OK, I'll add this in the next days, to be finished probably this weekend. I'm not a translator, so perhaps @abdel792, @CyrilleB79, @wmhn1872265132 and and others may want to review or comment on this. |
|
Following @seanbudd's suggestion, I wonder if it might be useful to create a dedicated Something like: Where the two documents target different audiences.
In that case, This might make the documentation easier to maintain and easier to navigate for both add-on authors and translators. |
|
As a follow-up to my previous comment, I have attached draft versions of: I have also included below a small proposal for updating the translation section of @nvdaes, since you mentioned that you plan to work on this over the next few days, I thought these drafts might be useful as a starting point for your next commit on this PR. Feel free to reuse, modify, reorganize, or discard any part of them if they are helpful. My intention was mainly to provide a concrete example of how the documentation could be split between add-on authors/maintainers and translators, following @seanbudd's suggestion. Proposed replacement for the current translation section in ## Add-on translations
The NVDA Add-on Template includes built-in support for Crowdin-based translation workflows.
Translation support covers both user interface translations (`.po` files) and documentation translations (`.xliff` files).
Depending on your role, please refer to the appropriate documentation:
* Translation guide for add-on authors
* Translation guide for translators
These documents explain how translation synchronization works and how translations are contributed through Crowdin. |
|
@abdel792 , thanks so much! I'm including your work in this PR (credits to you, of course, and I'll aknowledge it when this is announced on mailing lists). |
|
@abdel792 , I've included your files with some modifications. In particular, I've removed the section about documentation for add-on authors, since there is not a section about interface. Also, I've added links and tried to highlight that the whole scripts folder should be used. Note that it contains languageMappings and setOutputs.py (used to store the add-on ID as an output in GitHub Actions, based on buildVars.py. Also, note that GitHub Actions are using the nvdlUtil.exe file from nvaccess/nvdaL10n, which contains the configuration to use the NVDA add-ons Crowdin project. I think that we should mention that file instead of the l10nUtil.exe included in NVDA, but I'd like to request feedback by @seanbudd . For me, this is ready for NV Access review, but I've converted the PR to draft in case you @abdel792 want to review it. |
|
@nvdaes, thank you very much for the review and for integrating my contributions. I have looked through your latest changes and explanations, and everything looks good to me. Your adjustments make sense, especially the clarifications regarding the use of the whole scripts folder and the distinction between the I also agree that feedback from @seanbudd regarding the references to As far as I am concerned, I have nothing further to add at this stage. Thank you again for all the work you have put into this PR and for taking the time to refine and expand the documentation. This looks ready for NV Access review from my side. |
| @@ -0,0 +1,117 @@ | |||
| # Translation Guide for Add-on Authors | |||
There was a problem hiding this comment.
I think these files are better suited in the add-on template
There was a problem hiding this comment.
Can you also reference the template files from NVDA in projectDocs\dev\addons.md and projectDocs\translating\readme.md? We can also update the link from https://github.com/nvaccess/nvda/wiki/TranslatingAddons
|
I've created nvaccess/AddonTemplate#36 PR, adding docs to the template. Please note that credits about documentation should be given to @abdel792 . About adding this to the NVDA repo, I can do it, but perhaps it would be better that this work is made by @abdel792 . Please Abdel, let me know how to proceed. I think you haven't contributed to the NVDA project, you are an efficient developer and you may want to start contributing. |
|
Hi @nvdaes, Thanks for the kind words and for creating the AddonTemplate PR. I would be happy to submit the documentation changes to the NVDA repository myself. This would actually be my first contribution to the official NVDA documentation, so it will be a new experience for me. I'll try to work on it during the weekend and submit a PR updating Thanks again for the encouragement. |
|
@abdel792 wrote:
Great! As you know, in projectDocs/dev/contributing.md, you can find guidance, and a section is dedicated for first contributors. |
|
Thanks @nvdaes for the information and for pointing me to the contributor guide. I'll take a look at I'm glad to hear that the documentation has been merged into the addonTemplate. |
|
@abdel792 wrote:
First contribution to NVDA documentation but not first contribution to NVDA itself! |
|
I've just opened the PR: |
|
Thanks @CyrilleB79! You're right, I should have said my first contribution to the NVDA documentation. 😊 I had completely forgotten that I helped you with your first NVDA contribution. That's nice to hear! To me, it was only natural that we helped each other, as members of the NVDA community. Thank you for the encouragement and for your offer to help. I really appreciate it, and I won't hesitate to ask you, even in French, if I need some guidance. |
[Automated] Merged addons/placeMarkers/52.1.0.json into master (PR #1464)
|
can the added files be removed? |
|
@seanbudd wrote:
Done |
|
Apologies, I had merged the master from my fork. Now all should be fixed. |
### Link to issue number None ### Summary of the issue Documentation about add-on localization was recently added to the AddonTemplate repository. Relevant NVDA documentation pages did not yet reference these new resources. ### Description of user facing changes Added references to the AddonTemplate localization documentation for add-on authors and translators. ### Description of developer facing changes Developers and translators can now discover the add-on localization documentation directly from the NVDA documentation. ### Description of development approach Updated the following documentation pages to reference the localization guides recently added to the AddonTemplate repository: * `projectDocs/dev/addons.md` * `projectDocs/translating/readme.md` This work follows feedback provided during the review of [nvaccess/addon-datastore#9671](nvaccess/addon-datastore#9671). As part of that discussion, it was suggested that the NVDA documentation should reference the new add-on localization guides hosted in the AddonTemplate repository, replacing outdated references to the old TranslatingAddons wiki page. ### Testing strategy Verified that all added links point to the correct AddonTemplate documentation and that the modified Markdown renders correctly. ### Known issues with pull request None ### Checklist * [x] This change only affects documentation. * [x] Documentation has been updated accordingly. * [x] All added links have been verified. * [x] Markdown formatting has been reviewed. * [x] No code changes are included in this pull request. --------- Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Issue number
Fixes #2
Descriptions
This PR adds instructions about translating add-ons using the add-on template.