Handle modifications of existing add-on versions better#9862
Open
seanbudd wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure add-on submission validation failures (specifically modifications to an already-submitted add-on version) are surfaced back to the corresponding submission issue as a comment, addressing #2139.
Changes:
- Updates the changed-files detection script to emit a clearer validation message for “modified existing add-on version” cases and write it to
validationErrors.md. - Adds a workflow step to comment
validationErrors.mdon the submission issue and close the issue when determining the add-on filename fails.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/checkFilesChanged.js | Adjusts error handling for changed-files validation, including writing validationErrors.md for the “modified existing version” path. |
| .github/workflows/checkAndSubmitAddonMetadata.yml | Adds a failure-handling step to post validationErrors.md as an issue comment and close the issue when filename detection fails. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Sean Budd <seanbudd123@gmail.com>
seanbudd
commented
Jun 16, 2026
Signed-off-by: Sean Budd <seanbudd123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2139