Enable immutable releases#20345
Open
seanbudd wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the release workflow so the NVDA installer (output/nvda*.exe) is attached during gh release create, enabling GitHub Release immutability without breaking asset uploads.
Changes:
- Passes the built installer as an asset directly to
gh release create(stable releases), instead of uploading in a later step. - Removes the separate “upload exe to release assets” step from the workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
The step which uploaded the launcher for release-2026.2beta3 failed because I enabled release immutability in settings.
Now we can never upload the launcher to that release
Description of user facing changes:
none
Description of developer facing changes:
release exe is uploaded in same step of creation, so we can enable release immutability again
Description of development approach:
Testing strategy:
Known issues with pull request:
none
Code Review Checklist: