Skip to content

Enable immutable releases#20345

Open
seanbudd wants to merge 2 commits into
betafrom
immutableReleases
Open

Enable immutable releases#20345
seanbudd wants to merge 2 commits into
betafrom
immutableReleases

Conversation

@seanbudd

@seanbudd seanbudd commented Jun 16, 2026

Copy link
Copy Markdown
Member

Link to issue number:

None

Summary of the issue:

The step which uploaded the launcher for release-2026.2beta3 failed because I enabled release immutability in settings.
Now we can never upload the launcher to that release

Description of user facing changes:

none

Description of developer facing changes:

release exe is uploaded in same step of creation, so we can enable release immutability again

Description of development approach:

Testing strategy:

  • tested cli command locally

Known issues with pull request:

none

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd marked this pull request as ready for review June 16, 2026 05:19
@seanbudd seanbudd requested a review from a team as a code owner June 16, 2026 05:19
@seanbudd seanbudd requested review from SaschaCowley and Copilot June 16, 2026 05:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release workflow so the NVDA installer (output/nvda*.exe) is attached during gh release create, enabling GitHub Release immutability without breaking asset uploads.

Changes:

  • Passes the built installer as an asset directly to gh release create (stable releases), instead of uploading in a later step.
  • Removes the separate “upload exe to release assets” step from the workflow.

Comment thread .github/workflows/testAndPublish.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants