Skip to content

Set radio box layout for speech dictionary entry to vertical#20346

Closed
hwf1324 wants to merge 3 commits into
nvaccess:betafrom
hwf1324:entryTypesVerticalLayout
Closed

Set radio box layout for speech dictionary entry to vertical#20346
hwf1324 wants to merge 3 commits into
nvaccess:betafrom
hwf1324:entryTypesVerticalLayout

Conversation

@hwf1324

@hwf1324 hwf1324 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Link to issue number:

Related: #19657

Summary of the issue:

Currently, due to the large number of entry types in the speech dictionary, the add entry dialog box may extend beyond the screen area on smaller monitors.

Description of user facing changes:

Set the layout of the entry types radio box to vertical.

Description of developer facing changes:

Description of development approach:

Set style=wx.RA_SPECIFY_ROWS for wx.RadioBox.

Testing strategy:

Open the Add Entry dialog box and confirm that the radio box layout is vertical.

The entry layout is vertical.

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@hwf1324 hwf1324 requested a review from a team as a code owner June 16, 2026 02:24
@hwf1324 hwf1324 requested a review from seanbudd June 16, 2026 02:24

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hwf1324

@seanbudd

Copy link
Copy Markdown
Member

pre-commit.ci run

@hwf1324

hwf1324 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favor of #20347.

@hwf1324 hwf1324 closed this Jun 16, 2026
@hwf1324 hwf1324 deleted the entryTypesVerticalLayout branch June 16, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants