Add an optional argument to md2xliff command, to update from an old xliff file#8
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds an option to the md2xliff CLI command to reuse an existing XLIFF so existing translations can be carried forward when regenerating XLIFF from Markdown.
Changes:
- Added
-o/--oldXliffPathoption tomd2xliff. - When
--oldXliffPathis provided, preprocesses the old XLIFF and uses it to generate an updated output XLIFF. - Documented the new option in
readme.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| source/l10nUtil.py | Adds new md2xliff CLI option and branches into an “update from old XLIFF” workflow. |
| readme.md | Documents the new md2xliff option for preserving translations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Author
|
@copilot review again please |
seanbudd
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the issue
Updating xliff files was not posible with l10nUtil.exe.
Development approach
An optional --oldXliffPath (-o) argument has been added to the md2xliff command. If this argument is provided, markdownTranslate.updateXliff Will be used, after preprocessing the old xliff file to remove corrupt strings.
Testing performed
Tested locally, updating (and generating) an xliff file from the readme.md of this repo.
A new string has been added to the updated xliff. Note that, in the readme.md, a new string is added to document the new optional argument.