fix(#3327): pass nvim_tree.api.node.open.Opts to all applicable nvim_tree.api.node.open function#3329
Merged
Conversation
…tree.api.node.open function
…tree.api.node.open function
…tree.api.node.open function
…tree.api.node.open function
…tree.api.node.open function
alex-courtis
commented
May 14, 2026
| -- Parameter naming conventions: | ||
| -- `e` explorer | ||
| -- `n` node | ||
| -- `o` opts |
Member
Author
There was a problem hiding this comment.
We ran out of horizontal space, hence compressed the names.
alex-courtis
commented
May 14, 2026
|
|
||
| local mode_unsupported_focus = mode == "drop" or mode == "tab_drop" or mode == "edit_in_place" | ||
| local focus = edit_opts.focus == nil or edit_opts.focus == true | ||
| local focus = edit_opts.focus == nil or edit_opts.focus == false |
Member
Author
There was a problem hiding this comment.
This was incorrect. Fixed to match doc.
simonmandlik
approved these changes
May 15, 2026
Collaborator
simonmandlik
left a comment
simonmandlik
left a comment
There was a problem hiding this comment.
LGTM, thank you :)
| |:drop| | ||
|
|
||
| Parameters: ~ | ||
| • {node} (`nvim_tree.api.Node?`) directory or file |
Collaborator
There was a problem hiding this comment.
Why no quit_on_open and focus here?
Member
Author
There was a problem hiding this comment.
It looks like we had some logical or eventing problems with (tab_)drop and decided to exclude them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3327
Scope of changes: #3327 (comment)