Skip to content

Add advisory required checks ruleset#71

Merged
NWarila merged 1 commit into
mainfrom
step/STEP008-advisory-required-checks-ruleset
Jun 18, 2026
Merged

Add advisory required checks ruleset#71
NWarila merged 1 commit into
mainfrom
step/STEP008-advisory-required-checks-ruleset

Conversation

@NWarila

@NWarila NWarila commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add the advisory_checks YAML key and a CI Status Advisory baseline ruleset in evaluate mode.
  • Materialize that ruleset only when advisory_checks is non-empty.
  • Keep the existing required_checks to Pull Request Gate active enforcement path unchanged.
  • Add offline Terraform test coverage and ruleset documentation.

Validation

  • C:\tmp\terraform-1.15.4\terraform.exe -chdir=terraform fmt -check -recursive -diff - pass
  • C:\tmp\terraform-1.15.4\terraform.exe -chdir=terraform init -backend=false -reconfigure -input=false - pass
  • C:\tmp\terraform-1.15.4\terraform.exe -chdir=terraform validate -no-color - pass with pre-existing provider deprecation warning on github_actions_environment_secret.plaintext_value
  • C:\tmp\terraform-1.15.4\terraform.exe -chdir=terraform test -no-color - pass, 55 passed / 0 failed, with pre-existing provider deprecation warnings
  • C:\tmp\tflint-0.62.0\tflint.exe --chdir=terraform - pass
  • C:\tmp\terraform-docs-0.23.0\terraform-docs.exe --config .terraform-docs.yml --output-check terraform - pass
  • python tools\check_docs_layout.py - pass

Notes

No apply was run. A real terraform plan was not run because this configuration still requires S3 backend initialization for plan; the offline materialization/no-op proof is covered by the mock-provider terraform test plan assertions.

@NWarila NWarila marked this pull request as ready for review June 18, 2026 16:39
@NWarila NWarila merged commit 1f37c61 into main Jun 18, 2026
13 checks passed
@NWarila NWarila deleted the step/STEP008-advisory-required-checks-ruleset branch June 18, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant