Skip to content

ci: adopt reusable deploy workflow and move inventory to terraform/#29

Closed
NWarila wants to merge 1 commit into
mainfrom
ci/adopt-reusable-deploy
Closed

ci: adopt reusable deploy workflow and move inventory to terraform/#29
NWarila wants to merge 1 commit into
mainfrom
ci/adopt-reusable-deploy

Conversation

@NWarila

@NWarila NWarila commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Adopt the framework reusable deploy workflow and align the runner inventory layout to it.

Changes

  • Move the 20 public repo definitions repos/public/ -> terraform/public/ (pure renames) and update the deny-all .gitignore allowlist. The reusable overlays runner/terraform/{public,private}, so the inventory must live under terraform/.
  • Replace the inline terraform.yml job with a caller of reusable-terraform-deploy.yaml@37602cb8, adding import-adoption (no create-conflicts) and a plan_only dry-run on pull requests.
  • plan_only: github.event_name == pull_request -> PRs touching terraform/** get a no-apply plan preview; push to main / manual dispatch apply.
  • Drop the skip_refresh toggle (phantom state cleared in Drop 5 declarations for repos that no longer exist (unblocks terraform plan) #23) and the hardcoded owner (derived from github_owner).

Safety

  • State key unchanged: nwarila-platform/github-terraform-runner/terraform.tfstate.
  • All 20 inventory YAMLs verified git-tracked at the new path (no empty-inventory / destroy-all risk).

Switch the runner from the inline terraform.yml job to the framework's
reusable deploy workflow (import-adoption + plan_only dry-runs), and move
the repo inventory from repos/ to terraform/ to match the reusable's
overlay path. Pull requests now run a no-apply plan; push to main applies.
@NWarila NWarila force-pushed the ci/adopt-reusable-deploy branch from 984b2ff to 93f5a15 Compare June 20, 2026 01:16
@NWarila

NWarila commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

Closing: wrong approach. The canonical reusable (runner-protocol.md) uses an overlay_paths input (repos/public=>terraform/repos/public) to map the runner's existing layout, so moving the inventory to terraform/ is unnecessary; and credential-free PR plans use backend_mode: local, not a custom plan_only. The right path is to sync github-terraform-framework's reusable from NWarila/terraform-framework-template and adopt it per the documented protocol.

@NWarila NWarila closed this Jun 20, 2026
@NWarila NWarila deleted the ci/adopt-reusable-deploy branch June 20, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant