ci(runner): migrate inventory to terraform/ and adopt reusable deploy#32
Merged
Conversation
db9c261 to
5c37380
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge
This draft PR is intentionally a plan preview vehicle. It should not be merged until the pull-request
plan_onlyworkflow run has been audited and any required follow-up inventory corrections are folded into this same branch.Known blocker
The PR-head workflow starts in
plan_onlymode, skips OIDC, skips S3 private-definition fetch, overlays the runnerterraform/inventory, and runsterraform init -backend=false. It currently fails beforeterraform planin the reusable workflow'sAdopt existing repositories into statestep: the firstterraform importreportsBackend initialization requiredfor the configured S3 backend. No plan artifact is produced yet.A first run also exposed that the reusable's default
framework_refresolves to the runner PR merge SHA in this caller context. This branch now passesframework_ref: "37602cb8ff5d22aaebf4011eb02639de2ddbd6e3"to keep the reusable checkout on the same pinned framework revision.What changed
repos/public/toterraform/public/.terraform/private/.gitkeepso the reusable workflow's private overlay path exists while private definitions remain S3-backed..gitignoreallowlist fromrepos/toterraform/.37602cb8ff5d22aaebf4011eb02639de2ddbd6e3.framework_refso the reusable can check out the framework repository during PR runs.terraform/**withplan_only: ${{ github.event_name == 'pull_request' }}.Why
The reusable deploy workflow adds a pre-merge
plan_onlydry-run and import-adoption path. This makes the runner migration auditable before any S3-backed apply can touch the managed repository fleet.Validation
runner/terraform/publicandrunner/terraform/private.gh_token,framework_ref, andprivate_repos_files.git ls-files terraform/tracks 20 public YAML files plusterraform/private/.gitkeep.terraform/.git diff --check --cachedbefore commit.