Retry UDS drain on port exit to fix macOS CI race#5
Merged
Conversation
macOS runners can deliver the shepherd's Port {:exit_status} message
before the UDS buffer has MSG_CHILD_EXITED readable. A single 500 ms
recv then missed the payload, the status stayed :running, and 5 s
later :force_exit_timeout synthesised 137 — producing the flaky
{"", 137} instead of {"", 0} on echo-to-stderr fast-exit tests.
Replace the single call in maybe_read_exit_status with
drain_uds_for_exit/2: retry up to 5 times (2.5 s worst case) on
:no_message, stop immediately on :closed (shepherd died without
sending) or unexpected frames, and call finish_exit on success.
Still well under the 5 s force timeout fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS runners can deliver the shepherd's Port {:exit_status} message before the UDS buffer has MSG_CHILD_EXITED readable. A single 500 ms recv then missed the payload, the status stayed :running, and 5 s later :force_exit_timeout synthesised 137 — producing the flaky {"", 137} instead of {"", 0} on echo-to-stderr fast-exit tests.
Replace the single call in maybe_read_exit_status with drain_uds_for_exit/2: retry up to 5 times (2.5 s worst case) on :no_message, stop immediately on :closed (shepherd died without sending) or unexpected frames, and call finish_exit on success. Still well under the 5 s force timeout fallback.