fix: Early-return from VitePluginService::init() for console requests (#31)#32
Open
aedan-umd wants to merge 2 commits into
Open
fix: Early-return from VitePluginService::init() for console requests (#31)#32aedan-umd wants to merge 2 commits into
aedan-umd wants to merge 2 commits into
Conversation
aedan-umd
force-pushed
the
fix/console-request-early-return
branch
from
May 12, 2026 00:28
58d7bb3 to
3b74e82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #31 by an early-return from
VitePluginService::init()for console requests.Without this, on Craft 5.9.21 and above: SEOmatic's Install migration throws
The directory does not exist:when the bundle'ssourcePathalias hasn't been registered yet.Behavior change
Previously the inner CP/preview guard short-circuited on
getIsConsoleRequest(), but execution then fell through to thegetPublishedUrl()call regardless. After this change, all console requests bail out before that call, matching the behavior of the prior guard.useForAllRequests = truepaths are unaffected for web requests; console requests under that flag also now bail (they were previously broken on 5.9.21).