Add command option to allow passing Go package option.#132
Open
jasonfriedland wants to merge 1 commit intonytimes:masterfrom
Open
Add command option to allow passing Go package option.#132jasonfriedland wants to merge 1 commit intonytimes:masterfrom
jasonfriedland wants to merge 1 commit intonytimes:masterfrom
Conversation
Compiling a proto definition without a `go_package` option now generates
the following warning:
2020/11/12 15:09:19 WARNING: Missing 'go_package' option in "pkg/protobuf/api/api.proto",
please specify it with the full Go package path as
a future release of protoc-gen-go will require this be specified.
See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information.
This change allows the user to pass `-go-pkg` and have it used as the
value for `option go_package` in the generated .proto file.
Tested with protoc version 3.13.0.
|
this will be really nice to have... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling a proto definition without a
go_packageoption now generatesthe following warning:
This change allows the user to pass
-go-pkgand have it used as thevalue for
option go_packagein the generated .proto file.Tested with protoc version 3.13.0.