fix(cli): remove @o2s/framework refs from .storybook/main.ts during scaffold#841
Open
ysdy823 wants to merge 2 commits intoo2sdev:mainfrom
Open
fix(cli): remove @o2s/framework refs from .storybook/main.ts during scaffold#841ysdy823 wants to merge 2 commits intoo2sdev:mainfrom
ysdy823 wants to merge 2 commits intoo2sdev:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #836
After scaffolding with
create-o2s-app, Storybook fails because.storybook/main.tsstill contains references to@o2s/framework/sdkand@o2s/framework/modulesin bothresolve.alias(lines 92-93) andoptimizeDeps.include(lines 76-77), even thoughpackages/framework/is removed during scaffolding (listed inALWAYS_REMOVE_DIRS).Changes
packages/cli/create-o2s-app/src/scaffold/transform-storybook-config.ts— a transform that filters out lines containing@o2s/framework/references from.storybook/main.tspackages/cli/create-o2s-app/src/scaffold/index.ts— addedtransformStorybookConfigto the Step 4 parallel transform batchThe transform follows the same regex-based line-filtering pattern used by existing transforms (e.g.,
transform-app-module.ts).Test plan
npx create-o2s-appand scaffold a project.storybook/main.tsin the scaffolded project does not contain@o2s/frameworkreferencesnpm run storybook🤖 Generated with Claude Code
Summary by CodeRabbit