Merged
Conversation
Add arduino language support, since arduino is basically cpp, the chip refers to cpp.
Shrink the ASCII art to make the linter happy...
o2sh
reviewed
Sep 19, 2023
The ASCII art was mostly fine besides the trailing whitespace, and didn't need to be shrunk further. This reverts commit 161baa4.
spenserblack
approved these changes
Sep 19, 2023
Collaborator
spenserblack
left a comment
spenserblack
left a comment
There was a problem hiding this comment.
Don't have any more changes to request myself, but I'll leave it up to @o2sh to review styling.
Cleaner than mine ASCII art made by o2sh.
o2sh
approved these changes
Sep 20, 2023
Owner
o2sh
left a comment
o2sh
left a comment
There was a problem hiding this comment.
Thanks for your first contribution @sh4rk-byte and @spenserblack for the help!
🎉 ❤️
1 task
Collaborator
|
If you would like to help with #1152, we would appreciate your help over at gengo. What's most important to contribute is your familiarity with the language, so, even if you don't make a PR, you can make an issue. And whether you make a PR or just raise an issue describing the language, I'll add you to the credits 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add arduino language support, since arduino is basically cpp, the chip refers to cpp.