Conversation
spenserblack
left a comment
spenserblack
left a comment
There was a problem hiding this comment.
Merging this won't be possible right now because our current tool for language detection doesn't support Modelica. We'd need tokei to support Modelica, and also have a new release featuring that support.
That's the most significant blocking issue currently, though we may eventually switch tools for language detection.
|
I noticed the missing tokei support too and have now submitted a PR for that: XAMPPRocky/tokei#1061 |
|
@spenserblack Regarding #1152 , is there anything I could already do wrt adding Modelica in case that is resolved before |
|
Yeah you can make an issue or PR into https://github.com/spenserblack/gengo if you want. What's most important is knowledge, not code, so an issue is sufficient, but PRs are very welcome! |
spenserblack
left a comment
spenserblack
left a comment
There was a problem hiding this comment.
Alright, contribution LGTM. The only thing that's left is us resolving upstream issues, so I'm approving this.
|
Upstream has just merged the addition: XAMPPRocky/tokei#1061 |
|
We'll need to wait for the next release. |
…nto newlanguage-modelica
o2sh
left a comment
o2sh
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution @dietmarw 🎉
I took the liberty to clean the ASCII logo slightly https://vercel-gjf16v1xk-o2shs-projects.vercel.app/#Modelica
The PR should be ready to be merged
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [o2sh/onefetch](https://github.com/o2sh/onefetch) | minor | `2.22.0` -> `2.23.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>o2sh/onefetch (o2sh/onefetch)</summary> ### [`v2.23.1`](https://github.com/o2sh/onefetch/releases/tag/2.23.1) [Compare Source](o2sh/onefetch@2.23.0...2.23.1) <!-- Release notes generated using configuration in .github/release.yml at main --> ##### Bug Fixes 🐛 - Fix version in man page **Full Changelog**: o2sh/onefetch@2.23.0...2.23.1 ### [`v2.23.0`](https://github.com/o2sh/onefetch/releases/tag/2.23.0) [Compare Source](o2sh/onefetch@2.22.0...2.23.0) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### New Features 🎉 - add language support for OpenSCAD by [@​kenchou](https://github.com/kenchou) in o2sh/onefetch#1502 - add language support for Modelica by [@​dietmarw](https://github.com/dietmarw) in o2sh/onefetch#1262 - add language support for ATS by [@​pykenny](https://github.com/pykenny) in o2sh/onefetch#523 - add language support for CUDA by [@​jtmr05](https://github.com/jtmr05) in o2sh/onefetch#940 - add missing nerd fonts icons for some languages by [@​ankddev](https://github.com/ankddev) in o2sh/onefetch#1491 ##### Chores 🧹 - add Italian translation of README by [@​tlazzarin](https://github.com/tlazzarin) in o2sh/onefetch#1435 - add Polish translation of README by [@​adamperkowski](https://github.com/adamperkowski) in o2sh/onefetch#1444 - add Czech translation of READEME by [@​Amereyeu](https://github.com/Amereyeu) in o2sh/onefetch#1439 - update russian README by [@​ankddev](https://github.com/ankddev) in o2sh/onefetch#1478 - \[onefetch.dev] migrate to Svelte v5 by [@​o2sh](https://github.com/o2sh) in o2sh/onefetch#1455 - add script to preview/validate Nerd Fonts by [@​spenserblack](https://github.com/spenserblack) in o2sh/onefetch#1492 - add Powershell snippet to run onefetch automatically by [@​kiapanahi](https://github.com/kiapanahi) in o2sh/onefetch#1453 #### New Contributors - [@​tlazzarin](https://github.com/tlazzarin) made their first contribution in o2sh/onefetch#1435 - [@​kiapanahi](https://github.com/kiapanahi) made their first contribution in o2sh/onefetch#1453 - [@​adamperkowski](https://github.com/adamperkowski) made their first contribution in o2sh/onefetch#1444 - [@​Amereyeu](https://github.com/Amereyeu) made their first contribution in o2sh/onefetch#1439 - [@​ankddev](https://github.com/ankddev) made their first contribution in o2sh/onefetch#1478 - [@​kenchou](https://github.com/kenchou) made their first contribution in o2sh/onefetch#1502 - [@​dietmarw](https://github.com/dietmarw) made their first contribution in o2sh/onefetch#1262 - [@​pykenny](https://github.com/pykenny) made their first contribution in o2sh/onefetch#523 - [@​jtmr05](https://github.com/jtmr05) made their first contribution in o2sh/onefetch#940 **Full Changelog**: o2sh/onefetch@2.22.0...2.23.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS44Ni40IiwidXBkYXRlZEluVmVyIjoiMzkuODYuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Thanks @o2sh :-) |
3 participants
Purpose
Adding language support and icon art for Modelica.
Logo Reference