go/registry/api: Improve VerifyRuntime function signature and test suite#6512
Merged
martintomazic merged 7 commits intomasterfrom Apr 23, 2026
Merged
Conversation
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
martintomazic
commented
Apr 22, 2026
| isSanityCheck bool, | ||
| now beacon.EpochTime, | ||
| isFeatureVersion242 bool, | ||
| opts VerifyRuntimeOptions, |
Contributor
Author
There was a problem hiding this comment.
NIT: technically an API change, but don't think this was ever meant as an API/there are downstream users of this function...
martintomazic
force-pushed
the
martin/trivial/clean-test-verify-runtime
branch
5 times, most recently
from
5b94b98 to
29c6c9d
Compare
martintomazic
changed the title
martintomazic
changed the title
Subtest failing should not stop the whole table test.
martintomazic
force-pushed
the
martin/trivial/clean-test-verify-runtime
branch
from
29c6c9d to
de23626
Compare
peternose
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trivial
Doing this here to avoid clutter of #6474 and further duplication of code in the test suite.