ci: restore fmt + clippy gates and switch rust job back to Linux#342
Merged
ci: restore fmt + clippy gates and switch rust job back to Linux#342
Conversation
Followup to #319 (clippy unblocked), #320 (workspace fmt), #322 (submit classifier Linux-safe). - Add cargo fmt --all -- --check as the first rust-job step. - Add cargo clippy --workspace --all-targets --locked -- -D warnings before tests, so lint regressions block merge instead of leaking in. - Switch rust job from macos-latest back to ubuntu-latest. The platform-sensitive ECONNREFUSED classifier was fixed by #334 (substring match -> structured TransportErrorKind::HttpError.status check), so the macOS pin is no longer needed. Linux runners are faster and cheaper. Reviewer (blockchain-code-reviewer) confirmed step ordering, cache locality, action syntax, and permissions are clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo fmt --all -- --checkandcargo clippy --workspace --all-targets --locked -- -D warningsas the first two rust-job steps so lint and format regressions block merge.macos-latestback toubuntu-latest. The platform-sensitive ECONNREFUSED classifier insubmit.rswas fixed by fix(executor): classify HTTP errors via structured status, not substring (closes #322) #334, so the macOS pin is no longer required.Followup to #319 (clippy lint debt unblocked), #320 (workspace fmt), #322 (Linux submit classifier).
Test plan
ubuntu-latest.