Skip to content

Add timestamps for maven logs (#94) #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aequor-cntrl wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add timestamps for maven logs (#94) #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ec054b
Add timestamps for maven logs
aequor-cntrl Jul 23, 2025
ed57231
Add timestamp test
aequor-cntrl Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/mvnw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,21 @@ module.exports.mvnw = function(args, tgt, batch) {
return new Promise((resolve, reject) => {
target = tgt;
phase = args[0];
const jvmLogArgs = [
'-Dorg.slf4j.simpleLogger.showDateTime=true',
'-Dorg.slf4j.simpleLogger.dateTimeFormat=yyyy-MM-dd HH:mm:ss'
];
const home = path.resolve(__dirname, '../mvnw'),
bin = path.resolve(home, 'mvnw') + (process.platform === 'win32' ? '.cmd' : ''),
params = args.filter((t) => t !== '').concat([
'--batch-mode',
'--color=never',
'--update-snapshots',
'--fail-fast',
'--strict-checksums',
]),
params = jvmLogArgs.concat(
args.filter((t) => t !== '').concat([
'--batch-mode',
'--color=never',
'--update-snapshots',
'--fail-fast',
'--strict-checksums',
])
),
cmd = `${bin } ${ params.join(' ')}`;
console.debug('+ %s', cmd);
const result = spawn(
Expand Down
26 changes: 26 additions & 0 deletions test/test_mvnw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
*/

const {mvnw, flags} = require('../src/mvnw');
const { spawn } = require('child_process');
const assert = require('assert');

describe('mvnw', () => {
Expand All @@ -25,4 +26,29 @@ describe('mvnw', () => {
done();
});
});

it('includes timestamps in Maven logs', (done) => {
const mvnwPath = require('path').resolve(__dirname, '../mvnw/mvnw');
const args = [
'-Dorg.slf4j.simpleLogger.showDateTime=true',
'-Dorg.slf4j.simpleLogger.dateTimeFormat=yyyy-MM-dd HH:mm:ss',
'validate',
'--quiet'
];
const proc = spawn(mvnwPath, args);

let output = '';
proc.stdout.on('data', (data) => {
output += data.toString();
});
proc.stderr.on('data', (data) => {
output += data.toString();
});
proc.on('close', (code) => {
const lines = output.split('\n');
const hasTimestamp = lines.some(line => /\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/.test(line));
assert.ok(hasTimestamp, 'Maven output should include timestamps');
done();
});
});
});
Loading