#94 Enable slf4j-simple timestamps for Maven logs#909
Open
idrisoffrinat-cpu wants to merge 1 commit intoobjectionary:masterfrom
Open
#94 Enable slf4j-simple timestamps for Maven logs#909idrisoffrinat-cpu wants to merge 1 commit intoobjectionary:masterfrom
idrisoffrinat-cpu wants to merge 1 commit intoobjectionary:masterfrom
Conversation
Since Maven 3.1.x the distribution ships with slf4j-simple, which ignores the log4j configuration used by eo-maven-plugin. Pass the slf4j-simple system properties directly to every mvnw invocation so that timestamps appear in build logs, matching the format already used by log4j. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
@volodya-lombrozo please, take a look |
volodya-lombrozo
suggested changes
May 7, 2026
Member
volodya-lombrozo
left a comment
volodya-lombrozo
left a comment
There was a problem hiding this comment.
@idrisoffrinat-cpu great thanks for the contribution! Could you please add some tests that would prove the solution works?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #94.
Since Maven 3.1.x the distribution ships with
slf4j-simpleas the active SLF4J implementation, which ignores thelog4jconfiguration applied byeo-maven-plugin. As a result,eocoutput lacks per-line timestamps even though log4j formatting already sets them up.Passing the slf4j-simple system properties directly to every
mvnwinvocation makes the active logger emit timestamps in theyyyy-MM-dd HH:mm:ssformat, matching the approach suggested in the issue.Changes
src/mvnw.js: append-Dorg.slf4j.simpleLogger.showDateTime=trueand-Dorg.slf4j.simpleLogger.dateTimeFormat=yyyy-MM-dd HH:mm:ssto everymvnwcommand in the sharedparamsbuilder.Test plan
npx mocha test/test_mvnw.js— all 3 tests pass, and debug output confirms the flags are included in the constructed Maven command.npx eslint src/mvnw.js— clean.🤖 Generated with Claude Code