Narrow band and colour images#3
Conversation
jnation3406
left a comment
There was a problem hiding this comment.
The convert_to_planet_jpg and then planet_image_to_jpg methods should probably take in the params as well, and should respect the set values for width/height/quality at least. You can probably skip supporting label_text, and it already is supporting color.
Otherwise it looks good, but with the caveat that we call this from the archive to show thumbnails within the archive client UI, and I don't think we have any way of knowing if the image is of a planet from the data in the archive... unless its stored in the fits header somewhere? The target scheme being minor planet is in the request language for the observation, but not stored in the archives Frames model, so unless its in the fits header that might make knowing when to get planet jpegs harder from the archive client.
|
This got pushed down my list. Thanks for the suggestions @jnation3406 I've added your suggestions for parsing the I completely understand your caveat for thumbnails in the archive. |
I've updated the colour composite framework to include the narrowband filters for making colour images.
I've also added a planet option. This is different to the rest of the thumbnail code in that it always generates images of the same size 600 x 600 centred around a planet. The aim is to provide more reasonable scaling for planets which mostly lose their features when using
fits_to_jpg. It also balances the colours better in a colour image.I've added extra test coverage.
I will update the portal code to check for planets on the request (probably using the
scheme==JPL_MAJOR_PLANET)