Conversation
315cb8a to
689ebcd
Compare
|
Wow, great work! Initial thoughts:
More context around other improvements planned for daily_notes, not necessarily related to this PR:
Changes I would like to see:
local Periodic = {}
Periodic.__index = Periodic
---@param period_config obsidian.PeriodicConfig
---@return table Functions: this_period, last_period, next_period, period, period_note_path
Periodic.new = function(period_config)
return setmetatable(period_config, Periodic)
end
Periodic.this = function(self)
--- functions.this_period
--- access period_config like self.get_period_start, self.default_date_format
end
M.daily = Periodic.new(M.PERIODS.daily)
M.monthly = ...
|
|
@neo451 thank you for turning around a first pass on the review so quickly. I wanted to stick to the current pattern for a first pass (and I needed something functional for my workflow immediately). However, I agree the top level command noise is quite a lot here and there needs to be something to abstract that away. Very happy to revise some of this implementation with your design changes when I get some time here soon. |
|
Not sure if you're still working on this, but if you use Btw I'm personally more partial to just using the YYYY-MM-DD of the week's Monday. Because that gives me a better idea of when something happened when I look at my notes. |
|
I am, it's just been getting pushed further and further on my todo list. I'm hoping to come back to this before the end of the year here. I was thinking about if this week should belong to 2025-W52 or 2026-W1 a few days ago so good timing, thank you!! I'll be sure to add that change when I get a pass at this. edit : frazzled from the holidays it should definitely be 2026-W1, I see the problem... 🫠 |
807618c to
a3744f8
Compare
|
@neo451 I still need to update documentation on the commands, but I believe the design hits the architectural requests you had above and reduces the PR size quite significantly |
| end, | ||
| default_date_format = "%G-W%V", | ||
| default_alias_format = "Week %V, %G", | ||
| }, |
There was a problem hiding this comment.
Woohoo! Happy new year and happy week 2!
a3744f8 to
919d9bd
Compare
|
@mdavis36 sorry for no further response to your last comment for a long time, I did had to work on the moment module for this one to really work nicely, see |
Summary
Introduces a periodic notes system similar to daily notes, supporting:
All period types include:
Architecture Changes
New system:
Benefits:
New Commands
Weekly:
:Obsidian weekly [OFFSET]:Obsidian last_week, :Obsidian next_week:Obsidian weeklies [START] [END]Monthly:
:Obsidian monthly [OFFSET]:Obsidian last_month, :Obsidian next_month:Obsidian monthlies [START] [END]Quarterly:
:Obsidian quarterly [OFFSET]:Obsidian last_quarter, :Obsidian next_quarter:Obsidian quarterlies [START] [END]Yearly:
:Obsidian yearly [OFFSET]:Obsidian last_year, :Obsidian next_year:Obsidian yearlies [START] [END]Configuration
New config options mirroring daily_notes:
PR Checklist
CHANGELOG.mdis updatedREADME.mdfilemake chores(for style, lint, types, and tests)