Skip to content

deps.ffmpeg: Enable PDBs for FFmpeg builds on Windows#280

Merged
RytoEX merged 2 commits into
obsproject:masterfrom
RytoEX:add-ffmpeg-pdbs
May 20, 2026
Merged

deps.ffmpeg: Enable PDBs for FFmpeg builds on Windows#280
RytoEX merged 2 commits into
obsproject:masterfrom
RytoEX:add-ffmpeg-pdbs

Conversation

@RytoEX
Copy link
Copy Markdown
Member

@RytoEX RytoEX commented Mar 3, 2025

Description

Enable PDBs for FFmpeg builds on Windows if the Configuration is set to Debug or RelWithDebInfo.

Motivation and Context

Having PDBs for FFmpeg can be useful for debugging crashes. This was one of the original goals of moving the FFmpeg builds to be natively compiled.

How Has This Been Tested?

Tested locally about a year ago. Should probably be retested.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX requested a review from PatTheMav March 3, 2025 21:31
@RytoEX RytoEX self-assigned this Mar 3, 2025
Comment thread deps.ffmpeg/99-ffmpeg.ps1 Outdated
@RytoEX RytoEX force-pushed the add-ffmpeg-pdbs branch from dd5abd2 to a70121c Compare April 8, 2026 22:36
@RytoEX
Copy link
Copy Markdown
Member Author

RytoEX commented Apr 9, 2026

Just confirming that the recent push still creates PDBs for the DLLs:
image

Executables are suffixed for some reason:
image

The PDBs are not currently copied/installed to the install dir.

@RytoEX RytoEX force-pushed the add-ffmpeg-pdbs branch from a70121c to 79b5a3d Compare April 9, 2026 19:36
@RytoEX
Copy link
Copy Markdown
Member Author

RytoEX commented Apr 9, 2026

Apparently, I had forgotten to actually push the changes. The PDBs are still not actually part of any final artifacts, as I have to figure out where those are installed/copied.

@RytoEX RytoEX requested a review from PatTheMav May 6, 2026 17:53
@PatTheMav
Copy link
Copy Markdown
Member

PatTheMav commented May 6, 2026

Looking at my own code from the distance of a few years makes me want to refactor the entire build system for obs-deps, but that's a different story.. 😅

Enable PDBs for FFmpeg builds on Windows for all configurations. If the
configuration is set to Release, or RelWithDebInfo, or MinSizeRel,
adjust the linker options accordingly.
@RytoEX RytoEX force-pushed the add-ffmpeg-pdbs branch from 79b5a3d to 2191b6f Compare May 19, 2026 15:58
Comment thread deps.ffmpeg/99-ffmpeg.ps1 Outdated
@RytoEX RytoEX force-pushed the add-ffmpeg-pdbs branch from 2191b6f to 6f5ce98 Compare May 19, 2026 19:54
The make install command does not copy the PDBs to the install dir, so
we have to copy them manually.
@RytoEX
Copy link
Copy Markdown
Member Author

RytoEX commented May 20, 2026

Following up: PDBs are now manually copied to the install dir and are made part of the ffmpeg-windows-arm64 and ffmpeg-windows-x64 artifacts instead of being in separate artifacts. May change this later to split them out, but they add fairly little to the existing archive sizes (4~6 MB).

@RytoEX RytoEX force-pushed the add-ffmpeg-pdbs branch from 6f5ce98 to d239d02 Compare May 20, 2026 20:10
@RytoEX RytoEX merged commit 4979d6d into obsproject:master May 20, 2026
22 checks passed
@RytoEX RytoEX deleted the add-ffmpeg-pdbs branch May 20, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants