Skip to content

frontend: Use Qt parent-child ownership in OAuth dialog #12716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PatTheMav merged 2 commits into from
Oct 17, 2025
Merged

frontend: Use Qt parent-child ownership in OAuth dialog #12716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77faf01
frontend: Use Qt parent-child ownership in OAuth dialog
PatTheMav Oct 9, 2025
42159b4
obs-browser: Update version to 2.26.3
PatTheMav Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions frontend/dialogs/OAuthLogin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ OAuthLogin::OAuthLogin(QWidget *parent, const std::string &url, bool token) : QD

OBSBasic::InitBrowserPanelSafeBlock();

cefWidget = cef->create_widget(nullptr, url, panel_cookies);
cefWidget = cef->create_widget(this, url, panel_cookies);
if (!cefWidget) {
fail = true;
return;
Expand Down Expand Up @@ -71,15 +71,19 @@ int OAuthLogin::exec()
void OAuthLogin::reject()
{
#ifdef BROWSER_AVAILABLE
delete cefWidget;
if (cefWidget) {
cefWidget->closeBrowser();
}
#endif
QDialog::reject();
}

void OAuthLogin::accept()
{
#ifdef BROWSER_AVAILABLE
delete cefWidget;
if (cefWidget) {
cefWidget->closeBrowser();
}
#endif
QDialog::accept();
}
Expand Down
2 changes: 1 addition & 1 deletion plugins/obs-browser
Open in desktop
Submodule obs-browser updated 4 files
+1 −1 browser-version.h
+1 −1 panel/browser-panel-client.cpp
+1 −1 panel/browser-panel-internal.hpp
+67 −49 panel/browser-panel.cpp