frontend: Hide Twitch docks on minimized start

frontend/oauth/TwitchAuth.cpp

@@ -396,7 +396,7 @@ void TwitchAuth::LoadSecondaryUIPanes()
 		const char *dockStateStr = config_get_string(main->Config(), service(), "DockState");
 		QByteArray dockState = QByteArray::fromBase64(QByteArray(dockStateStr));
 
-		if (main->isVisible() || !main->isMaximized())
+		if (main->IsDeferringExtraDockVisibility() || main->isVisible() || !main->isMaximized())
 			main->restoreState(dockState);
 	}
 }

frontend/widgets/OBSBasic.cpp

@@ -1152,6 +1152,7 @@ void OBSBasic::OBSInit()
 	bool sysTrayWhenStarted = config_get_bool(App()->GetUserConfig(), "BasicWindow", "SysTrayWhenStarted");
 	bool hideWindowOnStart = QSystemTrayIcon::isSystemTrayAvailable() && sysTrayEnabled &&
 				 (opt_minimize_tray || sysTrayWhenStarted);
+	deferExtraDockVisibility = hideWindowOnStart;
 
 #ifdef _WIN32
 	SetWin32DropStyle(this);

frontend/widgets/OBSBasic.hpp

@@ -40,9 +40,11 @@
 #include <util/util.hpp>
 
 #include <QAccessible>
+#include <QPointer>
 #include <QSystemTrayIcon>
 
 #include <deque>
+#include <utility>
 
 extern volatile bool recording_paused;
 
@@ -62,6 +64,7 @@ class VolumeControl;
 class YouTubeAppDock;
 #endif
 class QMessageBox;
+class QShowEvent;
 class QWidgetAction;
 struct QuickTransition;
 
@@ -438,6 +441,9 @@ public slots:
 	QByteArray startingDockLayout;
 	QStringList extraDockNames;
 	QList<std::shared_ptr<QDockWidget>> extraDocks;
+	bool deferExtraDockVisibility = false;
+	bool hidingDeferredExtraDock = false;
+	QList<std::pair<QPointer<QDockWidget>, bool>> deferredExtraDockVisibility;
 
 	QStringList extraCustomDockNames;
 	QList<QPointer<QDockWidget>> extraCustomDocks;
@@ -450,8 +456,16 @@ public slots:
 	void RemoveDockWidget(const QString &name);
 	bool IsDockObjectNameUsed(const QString &name);
 	void AddCustomDockWidget(QDockWidget *dock);
+	bool IsDeferringExtraDockVisibility() const { return deferExtraDockVisibility; }
 	void setDockCornersVertical(bool vertical);
 
+protected:
+	void showEvent(QShowEvent *event) override;
+
+private:
+	void DeferExtraDockVisibility(QDockWidget *dock);
+	void RestoreDeferredExtraDockVisibility();
+
 private slots:
 	void on_resetDocks_triggered(bool force = false);
 	void on_lockDocks_toggled(bool lock);

frontend/widgets/OBSBasic_Docks.cpp

@@ -21,6 +21,8 @@
 
 #include <qt-wrappers.hpp>
 
+#include <QShowEvent>
+
 void setupDockAction(QDockWidget *dock)
 {
 	QAction *action = dock->toggleViewAction();
@@ -160,8 +162,10 @@ void OBSBasic::AddDockWidget(QDockWidget *dock, Qt::DockWidgetArea area, bool ex
 	else
 		ui->menuDocks->addAction(dock->toggleViewAction());
 
-	if (extraBrowser)
+	if (extraBrowser) {
+		DeferExtraDockVisibility(dock);
 		return;
+	}
 #else
 	UNUSED_PARAMETER(extraBrowser);
 
@@ -170,6 +174,7 @@ void OBSBasic::AddDockWidget(QDockWidget *dock, Qt::DockWidgetArea area, bool ex
 
 	extraDockNames.push_back(dock->objectName());
 	extraDocks.push_back(std::shared_ptr<QDockWidget>(dock));
+	DeferExtraDockVisibility(dock);
 }
 
 void OBSBasic::RemoveDockWidget(const QString &name)
@@ -218,6 +223,67 @@ void OBSBasic::AddCustomDockWidget(QDockWidget *dock)
 
 	extraCustomDockNames.push_back(dock->objectName());
 	extraCustomDocks.push_back(dock);
+	DeferExtraDockVisibility(dock);
+}
+
+void OBSBasic::DeferExtraDockVisibility(QDockWidget *dock)
+{
+	if (!deferExtraDockVisibility || !dock)
+		return;
+
+	for (auto &deferredDock : deferredExtraDockVisibility) {
+		if (deferredDock.first == dock)
+			return;
+	}
+
+	deferredExtraDockVisibility.append({dock, dock->isVisible()});
+
+	// When OBS starts hidden to tray, restoreState() can make floating
+	// extra docks visible before the main window is ever shown.
+	connect(dock, &QDockWidget::visibilityChanged, this, [this, dock](bool visible) {
+		if (!deferExtraDockVisibility || hidingDeferredExtraDock)
+			return;
+
+		for (auto &deferredDock : deferredExtraDockVisibility) {
+			if (deferredDock.first != dock)
+				continue;
+
+			deferredDock.second = visible;
+			if (visible && !isVisible()) {
+				hidingDeferredExtraDock = true;
+				dock->setVisible(false);
+				hidingDeferredExtraDock = false;
+			}
+			return;
+		}
+	});
+
+	if (dock->isVisible() && !isVisible()) {
+		hidingDeferredExtraDock = true;
+		dock->setVisible(false);
+		hidingDeferredExtraDock = false;
+	}
+}
+
+void OBSBasic::RestoreDeferredExtraDockVisibility()
+{
+	if (!deferExtraDockVisibility)
+		return;
+
+	deferExtraDockVisibility = false;
+
+	for (auto &deferredDock : deferredExtraDockVisibility) {
+		if (deferredDock.first)
+			deferredDock.first->setVisible(deferredDock.second);
+	}
+
+	deferredExtraDockVisibility.clear();
+}
+
+void OBSBasic::showEvent(QShowEvent *event)
+{
+	OBSMainWindow::showEvent(event);
+	RestoreDeferredExtraDockVisibility();
 }
 
 void OBSBasic::setDockCornersVertical(bool vertical)