frontend: Implement HealthCheck service and refactor Idian widgets#13433
Open
Warchamp7 wants to merge 7 commits into
Open
frontend: Implement HealthCheck service and refactor Idian widgets#13433Warchamp7 wants to merge 7 commits into
Warchamp7 wants to merge 7 commits into
Conversation
44e7c46 to
94f796f
Compare
The idian widgets were built when we had a much lower understanding of how Qt expects you to build custom complex widgets and without a direct use-case. They were also built far too rigid for what every attempted use of them thus far has necessitated. These changes break them into simpler 'pieces' and provide getters for internals that are intended to be accessed.
94f796f to
157dc39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
New widgets
Example image. Only Missing Files is implemented by this PR.
Motivation and Context
Currently we do not have a good way to surface information to users about configuration problems or other OBS 'System Health' issues. Often these warnings are part of startup, adding to an already large pile of dialogs and popups we can potentially spawn. In other cases, they are specific to particular settings themselves and only visible when the settings window is open and you are looking at the specific section or actual option.
This system aims to be for configuration warnings or problems which can be resolved, in contrast to a notification system.
I would appreciate feedback from people testing, as well as suggestions for which other settings issues or configuration might be good candidates to be added here.
How Has This Been Tested?
Created some test health items locally, as well as hooked up the scene collection missing files dialog to this system.
Expected behaviour is that Critical items will show in the list first, and fixed items will disappear.
Types of changes
Checklist: