Add (and use) a runner wrapping every test, to improve error reporting#303
Open
shym wants to merge 8 commits intoocaml-multicore:mainfrom
Open
Add (and use) a runner wrapping every test, to improve error reporting#303shym wants to merge 8 commits intoocaml-multicore:mainfrom
shym wants to merge 8 commits intoocaml-multicore:mainfrom
Conversation
This custom runner allows to display the result of a test in the same way on Unix and Windows (by mapping Windows error codes to their equivalent result on Unix) It also uses GitHub CI formats when available so that test failures are referenced as such at their positions in the logs
Unfortunately, syntax such as `%{dep:%{test}}` is not understood in an
action, and simply using: `(action (run runner %{test}))` does not add
the test executable to the dependencies of the action, so dune does not
build it
We keep the standard runner for the _internal_ tests, as the custom
runner would bring no benefit there
Also add a rule to build a dummy file in case the TIMELOGDIR was never set
Unix.time () does not fit inside a 31-bit int (which must be why it is using float in the first place), so use floats for times
Collaborator
Author
|
I’ve added the suggested improvements because I’d like to use them to work on my cygwin branch.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supersedes #205, providing a custom runner written in OCaml
Add a custom runner that allows to display the result of a test in the same way on Unix and Windows (by mapping Windows error codes to their equivalent result on Unix)
It also uses GitHub CI formats when available so that test failures are referenced as such at their positions in the logs
As it is written in OCaml (rather than bash), it opens some possible improvements: