Add STM_domain_eio and Lin_domain_eio libraries to run multicore tests with Eio #581
Open
lyrm wants to merge 6 commits intoocaml-multicore:mainfrom
Open
Add STM_domain_eio and Lin_domain_eio libraries to run multicore tests with Eio #581lyrm wants to merge 6 commits intoocaml-multicore:mainfrom
STM_domain_eio and Lin_domain_eio libraries to run multicore tests with Eio #581lyrm wants to merge 6 commits intoocaml-multicore:mainfrom
Conversation
and add new packages for eio-specific libraries instead.
Collaborator
|
Wow thanks for the contribution! 🥳 I've had a quick look and here are a bunch of non-organized impressions:
Thanks again! 😃 |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
qcheck-stm-eio.domainandqcheck-lin-eio.domainlibraries that provide Eio-based alternatives to the existing Domain-based libraries, spawning parallel tasks viaEio.Domain_managerinstead ofDomain.spawndirectly.This is needed for libraries built on Eio, such as Irmin and Lavyek.
Below, some technicals decisions that need discussions.
Dune rules to cp files
The shared code between
STM_domain/STM_domain_eioandLin_domain/Lin_domain_eiois factorised into*_commonmodules to minimise code duplication. To avoid creating a new library for each of these files, I added a dune rule to copy/paste the file. There may be a better way to do that.New packages
I added two packages (
qcheck-stm-eio.domainandqcheck-lin-eio.domain) instead of addingeioas a dependency for bothqcheck-linandqcheck-stm packages.TODO
qcheck-stm.domain_eioqcheck-lin.domain_eio*_eiolibraries to the CI checks.